Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T Seeded Cone jets update #43233

Merged
merged 15 commits into from
Jan 19, 2024
Merged

L1T Seeded Cone jets update #43233

merged 15 commits into from
Jan 19, 2024

Conversation

thesps
Copy link
Contributor

@thesps thesps commented Nov 9, 2023

In the context of phase 2 L1T emulation, this PR:

  • introduces the R=0.8 configuration for Seeded Cone jets (SC8)
  • renames existing Seeded Cone jet collections to 'SC4' for consistency
  • fixes some issues with bit-exact matching of the emulator wrt the firmware particularly for MHT
  • makes the jets/sums pattern file writer more flexible for testing against the firmware with different configurations (configurable input collections of jets and sums)

For testing, this CMSSW emulator now matches the firmware tested on an L1T board at the level of 99.9% for jets and 95% for sums (100% on the scalar sum and 95% on the vector sum due a difference in libraries for the trigonometry [std math vs hls math]).

thesps added 12 commits October 20, 2023 13:44
@thesps
Add SC8 jets. Rename SC jets to SC4. Add multiple outputs to jet file…
92ea3ea 
… writer

Fix merge issues
@thesps
Add MHT to jet writer output
498ed94
@thesps
Update jet writer for optional collections.
8570d4f
@thesps
Fixes for emulator-firmware correctness for HT. Initialise the packed…
41b686e 
… object word to 0 before packing. Round the eta limit to hardware units
@thesps
Add GT Sum unpack method
d9ba6fe
@thesps
Fix L1CTJetFileWriter fillDescriptions and l1tJetFileWriter_cfi
3cbf8e9
@thesps
apply code format
3539646
@thesps
Change configuration of L1CTJetFileWriter plugin with customisable nu…
0623fa3 
…mber of objects to write
@thesps
Sanitise GTSum pack/pack_ap. Perform HT emulator jet cuts in hardware…
abaf57e 
… units.
@thesps
Apply code format
b267d45
@thesps
Fix jet stream padding logic plus some cosmetics
03724e8
@thesps
Fix a naming issue after rebase
3ab8a93
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Nov 9, 2023
@thesps thesps mentioned this pull request Nov 9, 2023
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37588

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@thesps thesps changed the title Scj multiboard 13 3 0 pre3 L1T Seeded Cone jets update Nov 14, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37676

  • This PR adds an extra 64KB to repository

  • Found files with invalid states:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393d/36614/summary.html
COMMIT: 4bb3750
CMSSW: CMSSW_14_0_X_2023-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43233/36614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 1219
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246036
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

@epalencia I think I'm satisfied with this, we reviewed it in the L1 fork. Anything from your side?

@epalencia
Copy link
Contributor

+l1

This was referenced Jan 9, 2024
Merged
Merged
@epalencia
Copy link
Contributor

ping @cms-sw/upgrade-l2

@cmsbuild cmsbuild mentioned this pull request Jan 15, 2024
Merged
@srimanob
Copy link
Contributor

@cmsbuild please test

Just to trigger the test after a month.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393d/36916/summary.html
COMMIT: 4bb3750
CMSSW: CMSSW_14_0_X_2024-01-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43233/36916/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247526
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247501
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a4160c4 into cms-sw:master Jan 19, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Jan 20, 2024
Merged
@artlbv artlbv mentioned this pull request Jul 10, 2024
Merged
@thesps thesps mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
7 participants
@thesps @cmsbuild @epalencia @aloeliger @srimanob @subirsarkar @rappoccio